update deps 07 05 2021 #1411

thatStrangeGuyThorchain · 2021-05-10T10:43:02Z

Also includes manual clean-up of yarn.lock

packages not updated:

ncu
Using yarn
Checking /Users/achepurko/Documents/projects/asgardex-electron/package.json
[====================] 104/104 100%

 chart.js           ^2.9.4  →   ^3.2.1     // should be separate PR as it needed to migrate from 2x to 3x version
 cosmos-client     ^0.39.2  →  ^0.42.4     // should be updated at the `xchain-cosmos` first
 react-chartjs-2   ^2.11.1  →   ^3.0.3     // same as `chart.js`
 rxjs               ^6.6.7  →   ^7.0.0     // can not upgrade rxjs to 7x version as there is a conflict with
                                           // @devexperts/rx-utils/dist/observable.utils (see screenshot)
 @storybook/react  ^6.1.21  →   ^6.2.9     // depends on babel loader which version is now not acceptable from CRA
 prettier           ^2.2.1  →   ^2.3.0     // will be updated with next PR as it causes large diff
 ts-loader          ^8.1.0  →   ^9.1.2

ts-loader can not update to 9x version as it does not support webpack<5x which is used by craco

- craco/craco - openapitools/openapi-generator-cli - antd - axios - electron-log - ethers - fp-ts - fp-ts-rxjs - react-intl - styled-components - typescript

deps updated: - @storybook/addon-actions - @storybook/addon-controls - @storybook/addon-knobs - @storybook/addon-links - @storybook/addon-viewport - @storybook/addons - @storybook/theming - @testing-library/jest-dom - @testing-library/react-hooks - @testing-library/user-event - @types/fs-extra - @types/jest - @types/react - concurrently

- concurrently - eslint-config-prettier - eslint-plugin-prettier - node-abi - testcafe - ts-jest - webpack-cli

- electron - electron-builder

veado

From prettier blog about Prettier 2.3. https://prettier.io/blog/2021/05/09/2.3.0.html

This release focuses on fixing long-standing issues in the JavaScript printer. Be warned that, unfortunately, reformatting a project with the new version might result in quite a big diff. If you don’t use ignoreRevsFile to hide such wholesale changes from git blame, it might be about time.

Pls try to revert changes made by latest prettier to follow suggestion for using ignoreRevsFile , Iit might reduce these massive changes in this PR (hopefully)

package.json

This reverts commit df8bf13.

thatStrangeGuyThorchain · 2021-05-10T13:57:20Z

From prettier blog about Prettier 2.3. https://prettier.io/blog/2021/05/09/2.3.0.html

This release focuses on fixing long-standing issues in the JavaScript printer. Be warned that, unfortunately, reformatting a project with the new version might result in quite a big diff. If you don’t use ignoreRevsFile to hide such wholesale changes from git blame, it might be about time.

Pls try to revert changes made by latest prettier to follow suggestion for using ignoreRevsFile , Iit might reduce these massive changes in this PR (hopefully)

as discussed at the DMs all prettier-related changes will be moved to the separate PR as github does does not support such feature. it's only for local git blame configs

veado

Good work!

- electron@13, misc. electron* packages - Node 14.17 (as same as Electron 13 is using) - Latest [email protected] - Latest `[email protected]` - [email protected] - [email protected] (upgrade to 0.9.x is not possible due issues with webpack 5 used by craco - still same issue as mentioned in #1411) - webpack-cli

## Notes - `yarn.lock` has been created from scratch (by removing it before running `yarn`) - Node version update to `14.17` (as same as Electron@13 is using - see https://www.electronjs.org/releases/stable?version=13&page=2#13.0.0) - `.storybook/main.js` defines `reactDocgen: 'react-docgen'` temporary (just as a workaround as mentioned in styleguidist/react-docgen-typescript#356 (comment)) - Upgrades to latest react-chart | [email protected] needs updates for data and style handling for `PoolDetailsChart*.ts` - Stick on `[email protected]` (even a minor update to `@0.39.13` breaks tests - see https://github.com/thorchain/asgardex-electron/pull/1579/checks?check_run_id=2903609210#step:8:27) - Following packages could not be updated (similar issues we had before in #1411) ```bash ncu Checking asgardex-electron/package.json [====================] 105/105 100% @storybook/react ^6.1.21 → ^6.3.0 // breaks build of storybook, it seems babel loader version is not compatible with current CRA (as mentioned in #1411) @types/node ^14.17 → ^15.12 // we stick on [email protected] used by [email protected] ts-loader ^8.3.0 → ^9.2.3 // not compatible w/ webpack <5.0 - see https://github.com/TypeStrong/ts-loader/releases/tag/v9.0.0 cosmos-client ^0.39.2 → ^0.42.5 // `xchain-cosmos` needs to be updated before ethers ^5.1.4 → ^5.3.1 // `xchain-ethereum` needs to be updated before rxjs ^6.6.7 → ^7.1.0 // `fp-ts-rxjs` + `@devexperts/rx-utils/dist/observable.utils` still depends on [email protected] ```

## Notes - `yarn.lock` has been created from scratch (by removing it before running `yarn`) - Node version update to `14.17` (as same as Electron@13 is using - see https://www.electronjs.org/releases/stable?version=13&page=2#13.0.0) - `.storybook/main.js` defines `reactDocgen: 'react-docgen'` temporary (just as a workaround as mentioned in styleguidist/react-docgen-typescript#356 (comment)) - Upgrades to latest react-chart | [email protected] needs updates for data and style handling for `PoolDetailsChart*.ts` - Stick on `[email protected]` (even a minor update to `@0.39.13` breaks tests - see https://github.com/thorchain/asgardex-electron/pull/1579/checks?check_run_id=2903609210#step:8:27) - Following packages could not be updated (similar issues we had before in thorchain/asgardex-electron#1411) ```bash ncu Checking asgardex-electron/package.json [====================] 105/105 100% @storybook/react ^6.1.21 → ^6.3.0 // breaks build of storybook, it seems babel loader version is not compatible with current CRA (as mentioned in #1411) @types/node ^14.17 → ^15.12 // we stick on [email protected] used by [email protected] ts-loader ^8.3.0 → ^9.2.3 // not compatible w/ webpack <5.0 - see https://github.com/TypeStrong/ts-loader/releases/tag/v9.0.0 cosmos-client ^0.39.2 → ^0.42.5 // `xchain-cosmos` needs to be updated before ethers ^5.1.4 → ^5.3.1 // `xchain-ethereum` needs to be updated before rxjs ^6.6.7 → ^7.1.0 // `fp-ts-rxjs` + `@devexperts/rx-utils/dist/observable.utils` still depends on [email protected] ```

thatStrangeGuyThorchain added 6 commits May 7, 2021 14:37

deps updated:

7ec492b

- craco/craco - openapitools/openapi-generator-cli - antd - axios - electron-log - ethers - fp-ts - fp-ts-rxjs - react-intl - styled-components - typescript

deps updated:

6b04d10

- concurrently - eslint-config-prettier - eslint-plugin-prettier - node-abi - testcafe - ts-jest - webpack-cli

deps updated:

4b3927b

- electron - electron-builder

updated fs-extra

a43c001

updated @types/node

df8bf13

thatStrangeGuyThorchain requested a review from veado May 10, 2021 10:43

thatStrangeGuyThorchain changed the title ~~Issue 1408/update deps 07 05 2021~~ update deps 07 05 2021 May 10, 2021

veado suggested changes May 10, 2021

View reviewed changes

package.json Outdated Show resolved Hide resolved

updated lint-staged and git-revision-webpack-plugin

89fd697

thatStrangeGuyThorchain force-pushed the issue-1408/update-deps-07-05-2021 branch from 8190df9 to 89fd697 Compare May 10, 2021 13:48

Revert "updated @types/node"

271c087

This reverts commit df8bf13.

thatStrangeGuyThorchain requested a review from veado May 10, 2021 13:57

veado approved these changes May 10, 2021

View reviewed changes

thatStrangeGuyThorchain merged commit c26d38c into develop May 10, 2021

thatStrangeGuyThorchain deleted the issue-1408/update-deps-07-05-2021 branch May 10, 2021 13:59

veado mentioned this pull request Jun 24, 2021

Resolve: Update npm dependencies (06-23-2021) #1579

Merged

gromxyz mentioned this pull request Sep 13, 2021

Resolve: Update npm dependencies (09-10-2021) #1749

Merged

11 tasks

gromxyz mentioned this pull request Oct 19, 2021

Resolve: Update to latest npm dependencies (19-10-2021) #1864

Merged

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update deps 07 05 2021 #1411

update deps 07 05 2021 #1411

thatStrangeGuyThorchain commented May 10, 2021 •

edited

Loading

veado left a comment •

edited

Loading

thatStrangeGuyThorchain commented May 10, 2021

veado left a comment

update deps 07 05 2021 #1411

update deps 07 05 2021 #1411

Conversation

thatStrangeGuyThorchain commented May 10, 2021 • edited Loading

veado left a comment • edited Loading

Choose a reason for hiding this comment

thatStrangeGuyThorchain commented May 10, 2021

veado left a comment

Choose a reason for hiding this comment

thatStrangeGuyThorchain commented May 10, 2021 •

edited

Loading

veado left a comment •

edited

Loading